Re: [PATCH v3 1/8] dt-bindings: reset: Add mt6589 toprgu reset IDs

On 27/08/2026 13:57, Luca Leonardo Scorcia wrote:

quoted

quoted

Then these bits stay as is in DTS but bindings header is not needed. You
can have of course DTS header, as we did in the past multiple times for
such hardware constants.

So I wrote above this to myself and can be ignored completely? Then why
would we not ignore your patches?

I am sorry, I'm definitely not ignoring reviews and I'm actually
trying to understand and fix my mistakes.
This reply refers to v3, but in v4 you reviewed earlier today I added
reset table support in the driver, therefore in v4 those constants are
IDs instead of bits (and it should help cleanup the other MediaTek
existing bindings if deemed necessary).
If they're IDs that describe actual hardware capabilities, shouldn't
they be located under devicetree/? (Again, I understood my mistake in
v3, but in v4 it should be fixed).

The IDs do not describe hardware capabilities, but ABI between hardware
(DTS) and software (Linux). If you do not have them in the software,
then the ABI is not used. I looked at your driver patch and did not find
usage of these. I found usage of mt8167 only, so mt8167 is fine. The one
here is not fine.


Best regards,
Krzysztof