Re: [PATCH 3/7] rust: crc_ccitt: add CRC-CCITT abstraction

From
Eric Biggers <ebiggers@kernel.org>
Date
2026-08-25 17:56:28
Also in
linux-crypto, lkml, rust-for-linux
Reply to
Ayush Singh, 2026-08-21
On Fri, Aug 21, 2026 at 10:55:41AM +0530, Ayush Singh wrote:
quoted
quoted
diff --git a/rust/kernel/crc_ccitt.rs b/rust/kernel/crc_ccitt.rs
new file mode 100644
index 000000000000..6042ada16967
--- /dev/null
+++ b/rust/kernel/crc_ccitt.rs
Is there a reason why the kconfig symbol is being put in lib/crc/ but
the actual code is being put in rust/kernel/?  It seems inconsistent.

- Eric

Was copying `RUST_SERIAL_DEV_BUS_ABSTRACTIONS`. It is also in
`drivers/tty/serdev/Kconfig`.
kconfig options usually should be in the same directory as the code they
control.

- Eric
Thread (23 messages) 23 messages, 6 authors, last reply 2026-08-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help