Re: [PATCH v3 37/47] arm64: dts: qcom: sdx75: Add GCC CX power domain
From: sashiko-bot@kernel.org
Date: 2026-08-24 12:28:19
Also in:
linux-clk
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `power-domains` property is added to the GCC device tree node, but it is not documented in the corresponding `qcom,sdx75-gcc.yaml` device tree binding schema. --
--- Patch [37]: [PATCH v3 37/47] arm64: dts: qcom: sdx75: Add GCC CX power domain ---commit 31a230bc14fd1ed4b8fc915db1a0015701f6c99b Author: Abel Vesa [off-list ref] arm64: dts: qcom: sdx75: Add GCC CX power domain This commit adds a reference to the RPMh CX power domain in the SDX75 GCC node. This allows consumers of GCC-provided GDSCs to propagate their local domain votes to the required CX state.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi index 85cc9c6e6f83f..d4ef90c4a8db2 100644 --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi@@ -487,6 +487,7 @@ gcc: clock-controller@80000 { #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>; + power-domains = <&rpmhpd RPMHPD_CX>;
[Severity: Low] Will adding this property cause a dtbs_check validation regression? The Documentation/devicetree/bindings/clock/qcom,sdx75-gcc.yaml schema does not appear to document the power-domains property, and it enforces unevaluatedProperties: false. Does the schema need to be updated alongside this change to prevent validation errors? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260824-qcom-tie-cx-to-gcc-v3-0-f1205a92682b@oss.qualcomm.com?part=37