Re: [PATCH v5 1/6] dt-bindings: display: Add Solomon SSD1351 OLED controller
From: sashiko-bot@kernel.org
Date: 2026-08-23 11:28:17
Also in:
dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The binding is missing controller-specific default values for `solomon,width` and `solomon,height`. --
--- Patch [1]: [PATCH v5 1/6] dt-bindings: display: Add Solomon SSD1351 OLED controller ---commit c53d1459d9817dd8adf46b673b2d950a10a1775b Author: Amit Barzilai [off-list ref] dt-bindings: display: Add Solomon SSD1351 OLED controller This commit adds a device tree binding for the Solomon SSD1351 128x128 65k-color RGB OLED display controller. It leverages the shared solomon,ssd-common.yaml properties used by other Solomon display controllers.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml new file mode 100644 index 0000000000000..80850c2ab5b3e --- /dev/null +++ b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml
[ ... ]
+allOf: + - $ref: solomon,ssd-common.yaml# + +properties: + compatible: + enum: + - solomon,ssd1351
[Severity: Low] Should this properties block also declare default values for solomon,width and solomon,height? Other bindings that include solomon,ssd-common.yaml, such as solomon,ssd133x.yaml, establish default geometry values for their specific compatible strings in this block. Without these default values, device trees that omit the width and height properties will lack a schema-defined default geometry. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260823111959.17029-1-amit.barzilai22@gmail.com?part=1