Thread (14 messages) 14 messages, 4 authors, 2026-08-23

Re: [PATCH v6 1/6] dt-bindings: iio: dac: ad5504: add output-range and missing gpios

flat view

From: Jonathan Cameron <jic23@kernel.org>
Date: 2026-08-23 01:36:21
Also in: linux-iio, lkml

On Sat, 22 Aug 2026 17:37:22 -0500
David Lechner [off-list ref] wrote:
On 8/22/26 2:36 PM, Taha Ed-Dafili wrote:
quoted
quoted
This is one that is starting to emerging as a common name, so I would
call it clear-gpios instead to match the same name on chips with a
similar function.  
Worth noting Nuno asked for the opposite in v2 review, specifically
to match the datasheet's /CLR pin name:  
Normally I advocate for matching the pin name too. But there are some common
things like reset-gpios where we try to always use the same name. This clear
input seems to be one of those common things.
quoted
https://lore.kernel.org/linux-iio/a79296dc96215a579c29c5c9eda464f818f050d6.camel@gmail.com/ (local)

Let me know which name you'd prefer given that context, and I'll
update it in v7.

Best Regards,
Taha Ed-Dafili  

There is only one binding currently with clr-gpios (adi,ltc2688).
That one is a reset I think. Includes "The control registers are cleared
to default values".  It sort of clears the DAC as the default is 0V
So probably like 3 below.
And only one with clear-gpios (adi,ad5791). Plus at least two more coming
soon [1] [2].
ad5701 clr sets it to a user defined value..  If that's left as default it
sets to 0. That does overwrite the dac register (table 9)

ad5529r actually calls it clear on the datasheet. And just sets DAC outputs
to 0 (including the registers)

dac8163 is 0 scale, or mid scale depending on part. Registers written.
In [3], there is a /CLR pin, but we called it reset-gpios because it also
resets the control registers.

I didn't re-check the datasheets on all of these, but hopefully we are being
consistent.
Other than the one that maybe should have been a reset and isn't :(

They aren't quite the same across parts but close enough perhaps to generalize
the binding with some flexibility in the description.

Jonathan
[1]: https://lore.kernel.org/linux-iio/20260820-ad5529r-driver-v9-2-ba62e0b2a816@analog.com/ (local)
[2]: https://lore.kernel.org/linux-iio/20260802-dac8163-work-v3-1-3ecc7bc66d0d@gmx.net/ (local)
[3]: https://lore.kernel.org/linux-iio/20240714133000.5866-5-kimseer.paller@analog.com/ (local)


  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help