Re: [PATCH v5 5/8] iio: light: ltr501: Drop duplicated error message
flat view
From: Jonathan Cameron <jic23@kernel.org>
Date: 2026-08-22 23:39:46
Also in:
linux-iio, lkml
On Mon, 17 Aug 2026 19:08:54 +0200 Esben Haabendal [off-list ref] wrote:
The dev_err() message was causing duplicated error messages, as devm_request_threaded_irq() calls dev_err_probe() on failure. Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Reviewed-by: Andy Shevchenko <redacted> Signed-off-by: Esben Haabendal <redacted>
I picked up a patch that does this from Pan Chuang back on July 27th. So dropped this one.
quoted hunk ↗ jump to hunk
--- drivers/iio/light/ltr501.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c index 7746d374688f..b36bd10a0262 100644 --- a/drivers/iio/light/ltr501.c +++ b/drivers/iio/light/ltr501.c@@ -1537,11 +1537,8 @@ static int ltr501_probe(struct i2c_client *client) IRQF_ONESHOT, "ltr501_thresh_event", indio_dev); - if (ret) { - dev_err(&client->dev, "request irq (%d) failed\n", - client->irq); + if (ret) goto powerdown_on_error; - } } else { indio_dev->info = data->chip_info->info_no_irq; }