Re: [PATCH] dt-bindings: net: ti,davinci-emac: Convert to DT schema
From: sashiko-bot@kernel.org
Date: 2026-08-17 22:57:33
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The patch adds a new YAML schema for the DaVinci EMAC but fails to delete the original text binding file. --
--- Patch [1]: [PATCH] dt-bindings: net: ti,davinci-emac: Convert to DT schema ---commit cf3960563a2013243fe811ff3c6e1c07a1de9ddc Author: Bhargav Joshi [off-list ref] dt-bindings: net: ti,davinci-emac: Convert to DT schema Convert Texas Instruments DaVinci EMAC binding from text to DT schema. Updates the binding to include previously undocumented properties, modifies required properties, and marks hwmods as deprecated.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/ti,davinci-emac.yaml b/Documentation/devicetree/bindings/net/ti,davinci-emac.yaml new file mode 100644
[Severity: Low] This isn't a bug, but did this commit miss deleting the original text binding? Looking at the tree, Documentation/devicetree/bindings/net/davinci_emac.txt is still present. Conversions to DT schema typically remove the old .txt file in the same patch to prevent having duplicate documentation.
quoted hunk ↗ jump to hunk
index 0000000000000..cb1394f6f2d40--- /dev/null +++ b/Documentation/devicetree/bindings/net/ti,davinci-emac.yaml@@ -0,0 +1,113 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260817-ti-davinci-emac-v1-1-022678d966e9@gmail.com?part=1