RE: Re: [PATCH v4 1/4] dt-bindings: pinctrl: add Ambarella CV75 pinctrl
From: Long Zhao <hidden>
Date: 2026-08-17 07:05:49
Also in:
linux-arm-kernel, linux-gpio, lkml
Hi Krzysztof, Thanks for the review. Agreed — the redundant $ref will be dropped. I'll fix this in the upcoming unified v5 series. Best regards, Long Zhao Ambarella Shanghai Co., Ltd -----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: Monday, August 17, 2026 14:44 To: Long Zhao <redacted> Cc: Linus Walleij <linusw@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Bartosz Golaszewski <brgl@kernel.org>; linux-gpio@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org Subject: [EXT] Re: [PATCH v4 1/4] dt-bindings: pinctrl: add Ambarella CV75 pinctrl On Fri, Aug 14, 2026 at 02:25:41PM +0800, Long Zhao wrote:
quoted hunk ↗ jump to hunk
+ - vin_master_sync + - vsync0 + - vsync1 + - vsync2 + - vsync3 + - wdt + + groups: + $ref: /schemas/types.yaml#/definitions/string-array
Why are you redefining existing property from pincfg bindings? Since this cannot be tested by automation, I will not provide final reviews. Best regards, Krzysztof ###################################################################### This EXTERNAL email has been scanned by Proofpoint Email Protect service. ********************************************************************** This email and attachments contain Ambarella Proprietary and/or Confidential Information and is intended solely for the use of the individual(s) to whom it is addressed. Any unauthorized review, use, disclosure, distribute, copy, or print is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message. Thank you.