Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `dp-connector` node and `remote-endpoint` link for the external DisplayPort output, leaving the `dp1_out` graph endpoint disconnected.
--
--- Patch [15]: [PATCH v2 15/17] riscv: dts: spacemit: k3-pico-itx: enable the DisplayPort output ---
commit 524eda119bdbf5fa2382226e4f89b196aad432d5
Author: Cody Kang [off-list ref]
riscv: dts: spacemit: k3-pico-itx: enable the DisplayPort output
This commit enables the second DPU and the associated DisplayPort controller
to provide output to the external DisplayPort connector on the Pico-ITX board.
quoted hunk ↗ jump to hunk
diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
index b89c1521e6649..6c31460990a75 100644
--- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
+++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
[ ... ]
quoted hunk ↗ jump to hunk
@@ -221,3 +222,13 @@ hub@1 {
&usb2_phy {
status = "okay";
};
+
+&dpu1_crtc0 {
+ status = "okay";
+};
+
+&dp1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&dp1_1_cfg>;
+ status = "okay";
+};
[Severity: Low]
Does this device tree need a dp-connector node and a remote-endpoint link
for the external DisplayPort output?
Since dp1 is enabled here without describing the physical downstream connector
or linking it to the output port, it appears to leave the dp1_out graph
endpoint disconnected.
Even though the display driver might handle this missing topology gracefully
by falling back to an internal connector initialization, could this omission
trigger dtbs_check graph warnings for the dangling endpoint?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260809-k3-display-v2-0-327d7910bf71@gmail.com?part=15