Thread (1 message) 1 message, 1 author, 1d ago

Re: [PATCH v5 2/3] i2c: nt72676: Add Novatek NT72676 I2C controller driver

From: <hidden>
Date: 2026-08-05 01:15:10
Also in: sashiko-reviews

From: Ben Huang <redacted>

On Tue, 04 Aug 2026 03:45:15 +0000, sashiko-bot@kernel.org wrote:
Thank you for your contribution! Sashiko AI review found 6 potential issue(s) to consider:
- [High] The driver unconditionally treats the first message of any 2-message transfer as a subaddress write, silently dropping it or misinterpreting read operations.
- [High] The interrupt handler returns IRQ_NONE without clearing the hardware interrupt if current_msg is NULL, causing an interrupt storm.
- [High] Lack of synchronization between the I2C transfer timeout path and the interrupt handler leads to a use-after-free of the message buffer.
- [High] The I2C controller hardware is disabled before unregistering the adapter, breaking concurrent ongoing transfers and client device removal.
- [High] The ISR fails to handle the enabled CLK_STR_TIMEOUT interrupt, leaving it asserted and causing an interrupt storm.
- [Medium] Hardware interrupts are left enabled if `i2c_add_adapter` fails during probe.
These issues will be reviewed and fedback soon.

Sincerely,
Ben Huang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help