Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The dt-binding allows `#phy-cells = 2` to represent PHY direction, but the corresponding driver `phy-rockchip-samsung-dcphy.c` was not updated to support this.
--
--- Patch [1]: [PATCH v2 1/4] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: support per-direction phys ---
commit 421d266fa3318c44780c09224a034b0edeca9db3
Author: Jason Yang [off-list ref]
Subject: dt-bindings: phy: rockchip,rk3588-mipi-dcphy: support per-direction phys
This commit updates the Rockchip RK3588 MIPI D-/C-PHY device tree binding
to support per-direction configuration. It changes the #phy-cells property
to allow either 1 or 2 cells, where the optional second cell specifies the
PHY direction (TX or RX).
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml
index c8ff5ba22a86b..68a43db9c6690 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml
@@ -20,12 +20,22 @@ properties:
maxItems: 1
"#phy-cells":
- const: 1
+ enum: [1, 2]
[Severity: Medium]
Will this new 2-cell configuration work with the current PHY driver?
Looking at samsung_mipi_dcphy_xlate() in
drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c, the driver explicitly
rejects anything other than 1 cell:
if (args->args_count != 1) {
dev_err(dev, "invalid number of arguments\n");
return ERR_PTR(-EINVAL);
}
If a device tree is updated to use the newly allowed 2-cell configuration
to specify TX/RX direction, won't phy_get() fail and return -EINVAL? Should
the driver be updated alongside the binding so consumers can successfully
acquire the PHY?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260726-dcphy-rx-v1-v2-0-cf9cc34a412a@gmail.com?part=1