Re: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory
From: sashiko-bot@kernel.org
Date: 2026-07-24 18:54:50
Also in:
linux-phy
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added drivers/phy/airoha/Kconfig and drivers/phy/airoha/Makefile are not covered by the MAINTAINERS entry. --
--- Patch [2]: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory ---commit 83a3c170a5f0894b166822d36bf49798d65f73e9 Author: Christian Marangi [off-list ref] phy: move and rename Airoha PCIe PHY driver to dedicated directory This commit moves the Airoha PCIe PHY driver to a dedicated directory and renames the files to specifically reference the AN7581 SoC. It also adds a new Kconfig and Makefile to the newly created drivers/phy/airoha/ directory to support future drivers for different SoCs.
quoted hunk ↗ jump to hunk
diff --git a/MAINTAINERS b/MAINTAINERS index cb7836a27b177..bbfaca572118c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -765,8 +765,8 @@ M: Lorenzo Bianconi <lorenzo@kernel.org> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained F: Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.yaml -F: drivers/phy/phy-airoha-pcie-regs.h -F: drivers/phy/phy-airoha-pcie.c +F: drivers/phy/airoha/phy-an7581-pcie-regs.h +F: drivers/phy/airoha/phy-an7581-pcie.c
[Severity: Low] This isn't a bug, but should the newly created drivers/phy/airoha/Kconfig and drivers/phy/airoha/Makefile files also be included in this entry? Currently, get_maintainer.pl might not automatically include the Airoha PCIe PHY driver maintainers for patches modifying those build files. Could this entry be simplified to cover the new files by using a directory match like "F: drivers/phy/airoha/" instead? [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260724184523.193661-1-ansuelsmth@gmail.com?part=2