[PATCH v4 17/21] media: imx355: Use NULL ctrl_ops for HBLANK as it is a read-only control
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
Date: 2026-07-15 11:44:27
Also in:
linux-media, lkml
Subsystem:
media input infrastructure (v4l/dvb), sony imx355 sensor driver, the rest, v4l2 camera sensor drivers · Maintainers:
Mauro Carvalho Chehab, Tianshu Qiu, Linus Torvalds, Sakari Ailus
This avoids the set_ctrl handler being called under any circumstances, as it will return an error for the unhandled ctrl. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- drivers/media/i2c/imx355.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
index cc27a193cd81..3b3bf41485c2 100644
--- a/drivers/media/i2c/imx355.c
+++ b/drivers/media/i2c/imx355.c@@ -1124,9 +1124,8 @@ static int imx355_init_controls(struct imx355 *imx355) 1, vblank_def); hblank = mode->llp - mode->width; - imx355->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &imx355_ctrl_ops, - V4L2_CID_HBLANK, hblank, hblank, - 1, hblank); + imx355->hblank = v4l2_ctrl_new_std(ctrl_hdlr, NULL, V4L2_CID_HBLANK, + hblank, hblank, 1, hblank); if (imx355->hblank) imx355->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
--
2.34.1