Re: [PATCH RFC 3/3] dt-bindings: iio: adc: Add burn-out current properties
From: sashiko-bot@kernel.org
Date: 2026-06-19 00:45:33
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The `burn-out-current-microamp` property lacks array bounds (e.g., `maxItems`), allowing unbounded arrays to silently pass schema validation. - [Low] The description for `burn-out-current-polarity` is incorrectly copy-pasted from `burn-out-current-microamp` and fails to describe the polarity property itself. -- commit a77887c22cdfb0d199c09b61e65157768374c14a Author: Kurt Borja [off-list ref] dt-bindings: iio: adc: Add burn-out current properties This commit adds the burn-out-current-microamp and burn-out-current-polarity properties to the generic IIO ADC bindings to allow configuration of burn-out current sources.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml@@ -106,6 +106,20 @@ properties: This array describes the current configuration of the excitation current sources or the single matched current for all sources. + burn-out-current-microamp: + description: + Burn-out current sources provide current to the channel's input pins for + open-circuit or short-circuit detection.
[Severity: Medium] Since standard device tree schema tools automatically map properties ending in "-microamp" to an array structure, does this property need an array bound like maxItems? Without bounds, the schema validator might incorrectly accept an array of arbitrary size instead of enforcing a single configuration value per channel.
+ + burn-out-current-polarity: + $ref: /schemas/types.yaml#/definitions/string + description: + Burn-out current sources provide current to the channel's input pins for + open-circuit or short-circuit detection.
[Severity: Low] This isn't a bug, but it looks like this description was copy-pasted from burn-out-current-microamp. Could the description be updated to explain what the polarity configuration (pull-up/pull-down) actually does?
+ enum: + - pull-up + - pull-down
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260618-new-channel-props-v1-0-963c1b5cf40a@gmail.com?part=3