Re: [PATCH 1/9] dt-bindings: nvmem: imx-ocotp: Add support for secure-enclave
From: sashiko-bot@kernel.org
Date: 2026-06-16 12:02:36
Also in:
imx
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added `secure-enclave` property lacks a vendor prefix. -- commit cf8315ecdb4e65137976e7833794688f5241f64e Author: Frieder Schrempf [off-list ref] dt-bindings: nvmem: imx-ocotp: Add support for secure-enclave Some SoCs like the i.MX9 family allow full access to the fuses only through the secure enclave firmware API. Add a property to reference the secure enclave node and let the driver use the API.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml index a8076d0e2737c..14a6429f4a4c0 100644 --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml@@ -53,6 +53,10 @@ properties: reg: maxItems: 1 + secure-enclave:
[Severity: Low] Does this new property need a vendor prefix? Since this appears to be specific to NXP/Freescale i.MX hardware for referencing the secure enclave firmware, it should likely be named with an appropriate vendor prefix like "fsl,secure-enclave" rather than as a standard generic property.
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: A phandle to the secure enclave node
+
clocks:
maxItems: 1-- Sashiko AI review · https://sashiko.dev/#/patchset/20260616-upstreaming-next-20260609-imx-ocotp-ele-v1-0-cb7f3698c3e6@kontron.de?part=1