Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The schema uses an invalid regex `^dai@[0-9]+$` that rejects valid hex unit addresses containing `a-f`, and the example incorrectly uses the decimal unit address `dai@16` instead of the expected hexadecimal `dai@10`.
- [Low] The `clock-names` and `clocks` properties define a strictly ordered array sequence, preventing developers from defining subsets of clocks (e.g., omitting `bclk` while supplying `eclk`).
--
commit 3b274d792c2aeffee37c0e3a9b1930eed072c203
Author: Mohammad Rafi Shaik [off-list ref]
ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode
This commit extends the qcom,q6apm-lpass-dais device tree binding to
explicitly describe DAI child nodes. It adds address and size cells,
along with a dai pattern property to define interface IDs and clocks.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
index 2fb95544db8b5..4c4c73778e238 100644
--- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
[ ... ]
quoted hunk ↗ jump to hunk
+# Digital Audio Interfaces
+patternProperties:
+ '^dai@[0-9]+$':
[Severity: Low]
Does this regex pattern incorrectly block valid hexadecimal device tree unit
addresses?
Device tree unit addresses are typically expected to be lowercase
hexadecimal. This pattern rejects valid hex addresses containing alphabetical
characters like a-f.
quoted hunk ↗ jump to hunk
+ type: object
+ description:
+ Q6DSP Digital Audio Interfaces.
[ ... ]
quoted hunk ↗ jump to hunk
+ clock-names:
+ minItems: 1
+ items:
+ - const: mclk
+ - const: bclk
+ - const: eclk
[Severity: Low]
By using a strict array sequence here, does this prevent developers from
defining flexible clock subsets?
The driver retrieves clocks individually by name and appears to handle
omitted clocks gracefully. If a hardware design omits bclk but uses eclk,
this strict sequence constraint would cause schema validation to fail.
[ ... ]
quoted hunk ↗ jump to hunk
examples:
- |
+ #include <dt-bindings/sound/qcom,q6afe.h>
+
dais {
compatible = "qcom,q6apm-lpass-dais";
#sound-dai-cells = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dai@16 {
+ reg = <PRIMARY_MI2S_RX>;
[Severity: Low]
Should this example use a hexadecimal unit address instead of decimal?
PRIMARY_MI2S_RX evaluates to decimal 16, which means the unit address
should be formatted as dai@10 to match the reg property and avoid
unit_address_vs_reg warnings during dtc checks.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260608023011.942228-1-mohammad.rafi.shaik@oss.qualcomm.com?part=1