Thread (3 messages) 3 messages, 2 authors, 2026-05-13

Re: [PATCH] arm64: dts: socfpga: agilex: remove unimplemented clock in smmu node

From: Dinh Nguyen <dinguyen@kernel.org>
Date: 2026-05-08 12:43:44
Also in: lkml


On 5/7/26 01:12, Adrian Ng Ho Yin wrote:
quoted hunk ↗ jump to hunk
Remove unimplemented AGILEX_L3_MAIN_FREE_CLK in smmu node to prevent probe
failure when smmu is enabled.

Signed-off-by: Adrian Ng Ho Yin <redacted>
---
  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 1 -
  1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index 0dfbafde8822..6bfee8263b3d 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -445,7 +445,6 @@ smmu: iommu@fa000000 {
  				<GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
  			stream-match-mask = <0x7ff0>;
  			clocks = <&clkmgr AGILEX_MPU_CCU_CLK>,
-				 <&clkmgr AGILEX_L3_MAIN_FREE_CLK>,
  				 <&clkmgr AGILEX_L4_MAIN_CLK>;
  			status = "disabled";
  		};
Hmm. not sure about this. When I added this, the documenation had the 
clock and it's defined in include/dt-bindings/clock/agilex-clock.h. But 
you're right, it's unimplemented in the clock driver, should the fix be 
to implement it in the clock driver?

Dinh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help