Hi Dennis,

Am Dienstag, 31. März 2026, 21:41:50 Mitteleuropäische Sommerzeit schrieb Dennis Gilmore:

On Wed, Mar 11, 2026 at 9:26 AM Alexey Charkov [off-list ref] wrote:

quoted

On Wed, Mar 11, 2026 at 5:29 AM Dennis Gilmore [off-list ref] wrote:

quoted

On Tue, Mar 10, 2026 at 7:20 PM Jimmy Hon [off-list ref] wrote:

quoted

<snip>

quoted

+
+       vcc5v0_otg: regulator-vcc5v0-otg {
+               compatible = "regulator-fixed";
+               enable-active-high;
+               gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_HIGH>;
+               pinctrl-names = "default";
+               pinctrl-0 = <&vcc5v0_otg_en>;
+               regulator-always-on;
+               regulator-boot-on;

regulator-always-on and regulator-boot-on does not seem right.

Why were these added? The vendor did not have them.
https://github.com/orangepi-xunlong/linux-orangepi/blob/232ed4b97b65da2b7b647c4e3c496f8594b9f3f1/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-pro.dts#L216-L226

Was this mistakenly taken from the regulator usb 20 which is powering
the onboard usb2.0 hub?
https://github.com/orangepi-xunlong/linux-orangepi/blob/232ed4b97b65da2b7b647c4e3c496f8594b9f3f1/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-pro.dts#L111-L119

It may have been a missreading of the schematic, but it was added to
get power to the USB3 port. before I added it devices plugged into the
USB 3 port would not power on

Hi Dennis,

The schematic says that this regulator supplies the VBUS voltage for
the USB3 part of your Type-A OTG connector. If you make it always-on,
you'll likely lose the possibility to use this port in device mode
(which you would need e.g. for flashing images over a USB cable in
U-boot which also takes device tree sources from Linux via
devicetree-rebasing).

You also link it up as the PHY supply of the USB2 controller, which
doesn't describe the actual hardware.

Please see if you'd rather define a connector node for your Type-A
port, and list this regulator as its VBUS supply explicitly. I've
recently submitted a patch [1] to make the "onboard_usb_dev" driver
take care of enabling VBUS in exactly this type of situations (it's in
usb-testing now and will hopefully hit -next sometime soon). If you
need an example for its use, please refer to [2].

Best regards,
Alexey

[1] https://lore.kernel.org/all/20260217-typea-vbus-v1-1-657b4e55a4c2@flipper.net/ (local)
[2] https://github.com/flipperdevices/flipper-linux-kernel/blob/2f814cdf07f50e901fc1b1328213e76460864c20/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts#L303-L328

Sorry for the delay, I am taking a look at it now. Please let me know
when it lands in -next. In the meantime, I believe what I have is in
good shape and is working well here. I am happy to make a change once
support lands upstream.

Review comments should be addressed before patches get applied.

So there is no waiting for "when it lands upstream" to make additional
fixes, when you know at submission time, that things need improvement.


Heiko