Re: [PATCH v8 13/13] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP
From: Mark Brown <broonie@kernel.org>
Date: 2026-03-31 19:17:44
Also in:
linux-arm-msm, linux-sound, lkml
On Mon, Mar 30, 2026 at 08:21:05AM +0000, Srinivas Kandagatla wrote:
quoted hunk ↗ jump to hunk
@@ -416,9 +415,10 @@ static int q6apm_dai_close(struct snd_soc_component *component, struct snd_pcm_runtime *runtime = substream->runtime; struct q6apm_dai_rtd *prtd = runtime->private_data; - if (prtd->state) { /* only stop graph that is started */ + if (prtd->state) { + /* only stop graph that is started */ q6apm_graph_stop(prtd->graph); - q6apm_unmap_memory_regions(prtd->graph, substream->stream); + q6apm_free_fragments(prtd->graph, substream->stream); } q6apm_graph_close(prtd->graph);
Given that we allocate the fragments before setting state it looks like there's a window where we might leak them. Please send an incremental patch for this if you're going to fix it, I've queued things for CI and will merge tomorrow unless something blows up.
Attachments
- signature.asc [application/pgp-signature] 488 bytes