Re: [PATCH v3 0/4] iio: adc: meson-saradc: add support for Meson S4
From: Jonathan Cameron <jic23@kernel.org>
Date: 2026-03-26 19:57:35
Also in:
linux-amlogic, linux-arm-kernel, linux-iio, lkml
On Wed, 25 Mar 2026 15:06:14 +0800 Nick Xie [off-list ref] wrote:
This series adds support for the SARADC IP block found in the Amlogic Meson S4 (S905Y4) SoC and enables it for the Khadas VIM1S board to support the onboard ADC 'Function' key. There are no known hardware differences between the SARADC on the S4 and the previous G12A generation. The S4 bindings utilize a fallback to G12A, but a dedicated driver match entry is included to ensure the correct part name is exposed to the userspace ABI.
Applied patches 1 and 2 to the togreg branch of iio.git.
Changes in v3: - Patch 1: Updated the commit message to explicitly explain why the comment regarding the generic fallback was added. - Patch 2: Retained the driver patch and updated the commit message to clarify that the dedicated match entry is kept specifically for userspace ABI naming purposes. - Link to v2: https://lore.kernel.org/all/20260323013408.429701-1-nick@khadas.com/ (local) Changes in v2: - Addressed feedback from Krzysztof Kozlowski: - Updated dt-bindings commit message to explain the hardware compatibility. - Separated the S4 compatible string in the YAML bindings to ensure it correctly falls back to the specific "amlogic,meson-g12a-saradc" rather than the generic "amlogic,meson-saradc". - Updated the S4 SoC dtsi to use the correct G12A fallback. - Added Martin's Reviewed-by tags where appropriate. - Link to v1: https://lore.kernel.org/all/20260228065840.702651-1-nick@khadas.com/ (local) Nick Xie (4): dt-bindings: iio: adc: amlogic,meson-saradc: add S4 compatible iio: adc: meson-saradc: add support for Meson S4 arm64: dts: amlogic: meson-s4: add internal SARADC controller arm64: dts: amlogic: meson-s4-s905y4-khadas-vim1s: add Function key support .../iio/adc/amlogic,meson-saradc.yaml | 4 ++++ .../amlogic/meson-s4-s905y4-khadas-vim1s.dts | 19 +++++++++++++++++++ arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 14 ++++++++++++++ drivers/iio/adc/meson_saradc.c | 8 ++++++++ 4 files changed, 45 insertions(+)