Re: [PATCH v4 1/4] dt-bindings: iio: adc: add AD4691 family
From: Jonathan Cameron <jic23@kernel.org>
Date: 2026-03-21 14:35:15
Also in:
linux-gpio, linux-iio, linux-pwm, lkml
On Fri, 20 Mar 2026 13:03:55 +0200 Radu Sabau via B4 Relay [off-list ref] wrote:
From: Radu Sabau <radu.sabau@analog.com> Add DT bindings for the Analog Devices AD4691 family of multichannel SAR ADCs (AD4691, AD4692, AD4693, AD4694). The binding describes the hardware connections: - Power domains: avdd-supply (required), vio-supply,
Bit odd to call out avdd-supply as required but not vio-supply
quoted hunk ↗ jump to hunk
ref-supply or refin-supply (external reference; the REFIN path enables the internal reference buffer), and an optional ldo-in-supply, that if absent, means the on-chip internal LDO will be used. - Optional PWM on the CNV pin selects CNV Burst Mode; when absent, Manual Mode is assumed with CNV tied to SPI CS. - An optional reset GPIO (reset-gpios) for hardware reset. - Up to four GP pins (gp0..gp3) usable as interrupt sources, identified in firmware via interrupt-names "gp0".."gp3". - gpio-controller with #gpio-cells = <2> for GP pin GPIO usage. - #trigger-source-cells = <1>: one cell selecting the GP pin number (0-3) used as the SPI offload trigger source. Two binding examples are provided: CNV Burst Mode with SPI offload (DMA data acquisition driven by DATA_READY on a GP pin), and Manual Mode for CPU-driven triggered-buffer or single-shot capture. Signed-off-by: Radu Sabau <radu.sabau@analog.com> --- .../devicetree/bindings/iio/adc/adi,ad4691.yaml | 173 +++++++++++++++++++++ MAINTAINERS | 7 + 2 files changed, 180 insertions(+)diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml new file mode 100644 index 000000000000..def9f32c78af --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml@@ -0,0 +1,173 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/adi,ad4691.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD4691 Family Multichannel SAR ADCs + +maintainers: + - Radu Sabau <radu.sabau@analog.com> + +description: | + The AD4691 family are high-speed, low-power, multichannel successive + approximation register (SAR) analog-to-digital converters (ADCs) with + an SPI-compatible serial interface. The ADC supports CNV Burst Mode, + where an external PWM drives the CNV pin, and Manual Mode, where CNV + is directly tied to the SPI chip-select. + + Datasheets: + * https://www.analog.com/en/products/ad4692.html
Odd ordering. Put them in numeric order.
+ * https://www.analog.com/en/products/ad4691.html + * https://www.analog.com/en/products/ad4694.html + * https://www.analog.com/en/products/ad4693.html + +$ref: /schemas/spi/spi-peripheral-props.yaml#
...
+ + interrupt-names: + description: Names of the interrupt lines, matching the GP pin names. + minItems: 1 + maxItems: 4 + items:
I think this wants to be an enum. Generally look for a similar example and copy it + test the resulting binding with latest version of the dts-schema.
+ - const: gp0 + - const: gp1 + - const: gp2 + - const: gp3 +