On Tue, Mar 17, 2026 at 03:12:11PM -0700, Guenter Roeck wrote:

Hi,

On 3/16/26 07:05, Oleksij Rempel wrote:

quoted

This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
Interface (MSDI) via the MFD framework.

Architecture overview:
* mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
   linear irq_domain. Harvests status bits from SPI MISO MSB.
* pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
   the MFD domain.
* hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
   fault alarms.
* mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
   temperature, VBATP) to an external ADC.

Initial pinctrl implementation by David Jander, reworked into this MFD
architecture.

Please have a look at the AI review feedback at
https://sashiko.dev/#/patchset/20260316140514.1406588-1-o.rempel%40pengutronix.de

It didn't run on all patches of the series, and I don't know how accurate
the feedback for the non-hwmon patches is, but at least for the hwmon
patch I agree with its findings.

There are valid findings. I'll address them. Thx!

Best Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |