Re: [PATCH v2] reset: spacemit: k3: Decouple composite reset lines
From: Yixun Lan <dlan@kernel.org>
Date: 2026-03-16 01:40:38
Also in:
linux-riscv, lkml, spacemit
Hi Krzysztof, On 09:53 Sun 15 Mar , Krzysztof Kozlowski wrote:
On Sat, Mar 14, 2026 at 08:27:25AM +0000, Yixun Lan wrote:quoted
Instead of grouping several different reset lines into one composite reset, decouple them to individual ones which make it more aligned with underlying hardware. And for DWC USB driver, it will match well with the number of the reset property in the DT bindings. The DWC3 USB host controller in K3 SoC has three reset lines - AHB, VCC, PHY. The PCIe controller also has three reset lines - DBI, Slave, Master. Also three reset lines each for UCIE and RCPU block. As an agreement with maintainer, the reset IDs has been rearranged as contiguous number and pushed as a fix for the driver, and reason is that there isn't any consumer of reset driver so far, so should not cause any ABI breakage. Also, the changes of DT binding header file and reset driver are merged together as one single commit to avoid git-bisect breakage. Fixes: 938ce3b16582 ("reset: spacemit: Add SpacemiT K3 reset driver)Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
I usually run "b4 prep --check" to do the check, but I do forget it this time, sorry about this.. will be more cautious next time With the check, the only problem I see is one double quotes missing at end of the line, for the code I didn't see any complaint, let me know if I overlooked anything? -- Yixun Lan (dlan)