Re: [PATCH v6 6/7] i3c: hub: Add support for the I3C interface in the I3C hub
From: Jorge Marques <hidden>
Date: 2026-03-10 09:25:52
Also in:
linux-i3c, lkml
On Tue, Mar 10, 2026 at 12:27:26PM +0530, Lakshay Piplani wrote:
quoted hunk ↗ jump to hunk
Add virtual I3C bus support for the hub and provide interface to enable or disable downstream ports. Signed-off-by: Aman Kumar Pandey <redacted> Signed-off-by: Vikash Bansal <redacted> Signed-off-by: Lakshay Piplani <redacted> --- Changes in v6: - Add support for the generic I3C interface in the I3C Hub --- --- MAINTAINERS | 3 + drivers/i3c/Kconfig | 15 ++ drivers/i3c/Makefile | 1 + drivers/i3c/hub.c | 459 ++++++++++++++++++++++++++++++++++++++++ include/linux/i3c/hub.h | 107 ++++++++++ 5 files changed, 585 insertions(+) create mode 100644 drivers/i3c/hub.c create mode 100644 include/linux/i3c/hub.hdiff --git a/drivers/i3c/hub.c b/drivers/i3c/hub.c new file mode 100644 index 000000000000..9cdea8635327 --- /dev/null +++ b/drivers/i3c/hub.c@@ -0,0 +1,459 @@
Hi Aman,
+static bool i3c_hub_master_supports_ccc_cmd(struct i3c_master_controller *controller,
+ const struct i3c_ccc_cmd *cmd)
+{
+ struct i3c_hub_controller *hub_controller;
+ struct i3c_hub *hub;
+
+ hub_controller = dev_get_drvdata(&controller->dev);
+ if (!hub_controller || !hub_controller->hub)
+ return -ENODEV;
+This method returns a bool, this is a signedness bug. Regards, Jorge
-- 2.25.1