On Wed, Mar 04, 2026 at 08:32:53PM +0530, Vikash Garodia wrote:

On 3/4/2026 5:23 AM, Dmitry Baryshkov wrote:

quoted

On Tue, Mar 03, 2026 at 11:43:40PM +0530, Vikash Garodia wrote:

quoted

On 2/28/2026 1:22 AM, Dmitry Baryshkov wrote:

quoted

On Fri, Feb 27, 2026 at 07:41:17PM +0530, Vikash Garodia wrote:

quoted

Kaanapali SOC brings in the new generation of video IP i.e iris4. When
compared to previous generation, iris3x, it has,
- separate power domains for stream and pixel processing hardware blocks
    (bse and vpp).
- additional power domain for apv codec.
- power domains for individual pipes (VPPx).
- different clocks and reset lines.

iommu-map include all the different stream-ids which can be possibly
generated by vpu4 hardware as below,
bitstream stream from vcodec
non-pixel stream from vcodec
non-pixel stream from tensilica
pixel stream from vcodec
secure bitstream stream from vcodec
secure non-pixel stream from vcodec
secure non-pixel stream from tensilica
secure pixel stream from vcodec
firmware stream from tensilica (might be handled by the TZ / hyp)

This patch is depend on the below dt-schema patch.
Link: https://github.com/devicetree-org/dt-schema/pull/184/changes/d341298d62805bc972dfba691da6b3b62aa3ff15
Signed-off-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
---
   .../bindings/media/qcom,kaanapali-iris.yaml        | 261 +++++++++++++++++++++
   include/dt-bindings/media/qcom,iris.h              |  18 ++
   2 files changed, 279 insertions(+)

+
+  iommu-map:
+    description: |
+        - bitstream stream from vcodec
+        - non-pixel stream from vcodec
+        - non-pixel stream from tensilica
+        - pixel stream from vcodec
+        - secure bitstream stream from vcodec
+        - secure non-pixel stream from vcodec
+        - secure non-pixel stream from tensilica
+        - secure pixel stream from vcodec
+        # firmware might be handled by the TZ / hyp
+        - firmware stream from tensilica

Why are you providing description as a list rather than describing each
item separately? Then you wouldn't need maxItems.

rewrote them as below and dropped maxItems. Please review.

iommu-map:
     $ref: /schemas/types.yaml#/definitions/uint32-matrix
     items:
       - description: bitstream stream from vcodec
         items:
           - description: Function ID
           - description: Phandle to IOMMU
           - description: IOMMU stream ID base
           - description: IOMMU stream ID mask
           - description: Number of stream IDs

I'm not a pro in the DT. Is the itemization of the first item reused for
the rest of the items?

yes. As a trial, if i remove one of the itemization from above schema, then
checker throws error saying 5x9 arguments in the example is *too long* as it
tries to fit it as per schema i.e 4x9.

Ack, thanks for the test!

quoted

quoted

       - description: non-pixel stream from vcodec
       - description: non-pixel stream from tensilica
       - description: pixel stream from vcodec
       - description: secure bitstream stream from vcodec
       - description: secure non-pixel stream from vcodec
       - description: secure non-pixel stream from tensilica
       - description: secure pixel stream from vcodec
       # firmware might be handled by the TZ / hyp
       - description: firmware stream from tensilica
     minItems: 8

quoted

quoted

+    $ref: /schemas/types.yaml#/definitions/uint32-matrix
+    items:
+      $ref: '#/definitions/iommu-types'
+      minItems: 5
+    minItems: 8
+    maxItems: 9
+

Regards,
Vikash

-- 
With best wishes
Dmitry