On Tue, Mar 03, 2026 at 07:10:49PM +1000, James Calligeros wrote:

On Tuesday, 3 March 2026 12:11:50 pm Australian Eastern Standard Time Kuninori 
Morimoto wrote:

quoted

quoted

+int snd_soc_dai_set_tdm_idle(struct snd_soc_dai *dai,
+			     unsigned int tx_mask, unsigned int rx_mask,
+			     int tx_mode, int rx_mode);

quoted

Do we need "rx_mode" ?
Only "tx_mode" is enough if my understanding was correct.

For our (Asahi) purposes yes, we only require TX. However, TAS2770 also
has a bus keeper on SDIN, and I suspect other hardware may too. Rather than
break the API later on should the need to configure this arise,
I decided to add the capability now. I am happy to get rid of it if
we think it is superfluous at this time though.

I do think it's reasonable to keep things symmetric, it's probably
better to have an API that's consistent even if some of the code doesn't
currently get used.