Re: [PATCH v1 1/8] dt-bindings: mfd: add NXP MC33978/MC34978 MSDI
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-02-26 08:16:28
Also in:
linux-gpio, linux-hwmon, lkml
On Wed, Feb 25, 2026 at 06:15:34PM +0100, Oleksij Rempel wrote:
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/nxp,mc33978.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP MC33978/MC34978 Multiple Switch Detection Interface + +maintainers: + - David Jander [off-list ref] + - Oleksij Rempel [off-list ref] + +description: |
Do not need '|' unless you need to preserve formatting.
+ The MC33978 and MC34978 are Multiple Switch Detection Interface (MSDI) + devices with 22 switch inputs, integrated fault detection, and analog + multiplexer (AMUX) for voltage/temperature monitoring. + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - nxp,mc33978 + - nxp,mc34978 + + reg: + maxItems: 1 + description: SPI chip select number + + spi-max-frequency: + maximum: 8000000 + description: Maximum SPI clock frequency (up to 8 MHz) + + interrupts: + maxItems: 1 + description: | + INT_B pin interrupt. Active-low, indicates pin state changes or + fault conditions. + + interrupt-controller: true + + '#interrupt-cells': + const: 2 + description: | + First cell is the IRQ number (0-21 for pins, 22 for faults). + Second cell is the trigger type (IRQ_TYPE_* from interrupt-controller.h). + + vddq-supply: + description: Digital supply voltage + + vbatp-supply: + description: Battery/power supply
This is incomplete. I see several other patches changing the file - please post complete binding in one patch, not half-baked solutions.
+ +required: + - compatible + - reg + - interrupts + - interrupt-controller + - '#interrupt-cells'
Supplies should be required, unless datasheet tells otherwise.
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/gpio/gpio.h>
+
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ msdi: mc33978@0 {Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation If you cannot find a name matching your device, please check in kernel sources for similar cases or you can grow the spec (via pull request to DT spec repo). Best regards, Krzysztof