Re: [PATCH 2/4] dt-bindings: usb: atmel,at91sam9g45-ehci: convert to DT schema
From: Charan Pedumuru <hidden>
Date: 2026-02-04 13:09:28
Also in:
linux-arm-kernel, linux-usb, lkml
On 03-02-2026 23:38, Rob Herring wrote:
On Mon, Feb 02, 2026 at 04:32:54PM +0530, Charan Pedumuru wrote:quoted
On 01-02-2026 18:07, Rob Herring (Arm) wrote:quoted
On Sun, 01 Feb 2026 11:34:21 +0000, Charan Pedumuru wrote:quoted
Convert Atmel AT91SAM9G45 EHCI USB Host Controller binding to DT schema. Changes during conversion: - Include "usb-ehci" as a fallback compatible to allow atmel EHCI driver matching. Signed-off-by: Charan Pedumuru <redacted> --- .../bindings/usb/atmel,at91sam9g45-ehci.yaml | 71 ++++++++++++++++++++++ 1 file changed, 71 insertions(+)My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Warning: Duplicate compatible "usb-ehci" found in schemas matching "$id": http://devicetree.org/schemas/usb/atmel,at91sam9g45-ehci.yaml http://devicetree.org/schemas/usb/generic-ehci.yaml# Warning: Duplicate compatible "atmel,at91sam9g45-ehci" found in schemas matching "$id": http://devicetree.org/schemas/usb/atmel,at91sam9g45-ehci.yaml http://devicetree.org/schemas/usb/generic-ehci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/atmel,at91sam9g45-ehci.example.dtb: usb@500000 (atmel,at91sam9g45-ehci): Unevaluated properties are not allowed ('clock-names' was unexpected) from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yamlHi Rob, Isn't it pointing to the other schema ID which was not defined by me?You can't have the same compatible defined in 2 places.
Okay.
quoted
Can I have your suggestion on changing the compatible name to other name to resolve this error?Why are you converting this? It's already covered by generic-ehci.yaml. Though I seem to recall there were some warnings for Atmel.
Yes, in that case I will drop this patch in the next revision.
quoted
I ran dt_check in my machine on the latest version and I don't see any error there.Please read the last paragraph below for why.
Okay, I understood now.
quoted
quoted
doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20260201-atmel-usb-v1-2-d1a3e93003f1@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.^^^^^^^ Rob
-- Best Regards, Charan.