Thread (20 messages) 20 messages, 5 authors, 2026-02-04

Re: [PATCH v9 7/7] i2c: xiic: skip input clock setup on non-OF systems

From: Andy Shevchenko <hidden>
Date: 2026-02-03 15:46:30
Also in: linux-arm-kernel, linux-i2c, lkml

On Mon, Feb 02, 2026 at 08:37:24PM +0000, Abdurrahman Hussain via B4 Relay wrote:
Currently Linux does not implement ACPI ClockInput to describe clock
ClockInput() resource
resources, unlike DT. However the xiic driver is happy if something
magically enables the clock before the driver probes, and does not
turn it off again. The clock should always be considered optional for
ACPI.
...
+	if (is_of_node(dev_fwnode(dev))) {
+		i2c->clk = devm_clk_get_enabled(dev, NULL);
+		if (IS_ERR(i2c->clk))
+			return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
Haven't you seen my previous comments? Why 'pdev'?
+					"failed to enable input clock.\n");
+	}
-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help