Re: [PATCH v3 7/8] iio: dac: ds4424: convert to regmap
From: Sander Vanheule <sander@svanheule.net>
Date: 2026-02-01 19:35:53
Also in:
linux-iio, lkml
Hi Oleksij, On Wed, 2026-01-28 at 16:38 +0100, Oleksij Rempel wrote:
+static const struct regmap_config ds44x2_regmap_config = {
+ .reg_bits = 8,
+ .val_bits = 8,
+ .cache_type = REGCACHE_MAPLE,
+ .max_register = DS4424_DAC_ADDR(1),
+ .rd_table = &ds44x2_table,
+ .wr_table = &ds44x2_table,
+ /* Seed cache from HW during regmap_init */Nit: You're seeding the cache (manually) in ds4424_init_regmap(). But you can also just drop this comment as far as I'm concerned. The comment in ds4424_init_regmap() explains it sufficiently.
+ if (ret) + return dev_err_probe(&client->dev, ret, + "Failed to read hardware defaults\n");
Nit: "hardware defaults" -> "hardware values" Nothing too serious from my side, so FWIW, with these things addressed: Reviewed-by: Sander Vanheule <sander@svanheule.net> Best, Sander