Re: [PATCH 1/8] dt-bindings: clock: qcom: Add X1P42100 video clock controller
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-01-28 11:43:39
Also in:
linux-arm-msm, linux-clk, lkml
On Wed, Jan 28, 2026 at 12:56:32AM +0530, Jagadeesh Kona wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/dt-bindings/clock/qcom,x1p42100-videocc.h b/include/dt-bindings/clock/qcom,x1p42100-videocc.h new file mode 100644 index 0000000000000000000000000000000000000000..eb6c9b7264f8cbced7cfa0001903238ffa168431 --- /dev/null +++ b/include/dt-bindings/clock/qcom,x1p42100-videocc.h@@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +#ifndef _DT_BINDINGS_CLK_QCOM_VIDEO_CC_X1P42100_H +#define _DT_BINDINGS_CLK_QCOM_VIDEO_CC_X1P42100_H + +#include "qcom,sm8650-videocc.h"
Don't do this. It's already a mess and was allowed as an exception. Now you grow exception into pattern of chained bindings.
+ +/* X1P42100 introduces below new clocks and resets compared to SM8650 */
Best regards, Krzysztof