Re: [PATCH v2 4/8] iio: dac: ds4424: sort headers alphabetically
From: Andy Shevchenko <hidden>
Date: 2026-01-27 10:30:18
Also in:
linux-iio, lkml
On Tue, Jan 27, 2026 at 07:09:35AM +0100, Oleksij Rempel wrote:
Sort the header inclusions alphabetically. This improves readability and simplifies adding new includes in the future.
...
-#include <linux/kernel.h> -#include <linux/module.h> -#include <linux/i2c.h> -#include <linux/regulator/consumer.h> -#include <linux/err.h> #include <linux/delay.h> -#include <linux/iio/iio.h> +#include <linux/err.h> +#include <linux/i2c.h>
+#include <linux/iio/consumer.h> #include <linux/iio/driver.h> +#include <linux/iio/iio.h> #include <linux/iio/machine.h> -#include <linux/iio/consumer.h>
This was at the end and I assume we want this to be kept at the end as a separate group of linux/iio/* to emphasize on the fact that the driver is related to that subsystem.
+#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/regulator/consumer.h>
With that being said, I think the result should look as #include <linux/delay.h> #include <linux/err.h> #include <linux/i2c.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/regulator/consumer.h> #include <linux/iio/consumer.h> #include <linux/iio/driver.h> #include <linux/iio/iio.h> #include <linux/iio/machine.h> -- With Best Regards, Andy Shevchenko