Re: [PATCH v3 1/3] dt-bindings: gpio: Add Tegra264 support
From: Conor Dooley <conor@kernel.org>
Date: 2026-01-23 17:16:03
Also in:
linux-gpio, linux-tegra, lkml
On Fri, Jan 23, 2026 at 10:08:22AM +0000, Prathamesh Shete wrote:
quoted hunk ↗ jump to hunk
Extend the existing Tegra186 GPIO controller device tree bindings with support for the GPIO controller found on Tegra264. The number of pins is slightly different, but the programming model remains the same. Add a new header, include/dt-bindings/gpio/tegra264-gpio.h, that defines port IDs as well as the TEGRA264_MAIN_GPIO() helper, both of which are used in conjunction to create a unique specifier for each pin. On Tegra, GPIO wake events are latched and routed via the PMC. Document the standard DT property, wakeup-parent, which is a phandle to the PMC interrupt controller that provides the parent wake interrupt domain for the GPIO controller. If the property is absent the driver falls back to a compatible-based lookup. Signed-off-by: Prathamesh Shete <redacted> --- Changes in v3: * Fix DT binding SPDX license to GPL-2.0-only OR BSD-2-Clause Changes in v2: * Update DT binding to use “wakeup-parent” (drop custom nvidia,pmc). * Require “wakeup-parent” for Tegra264 compatibles in the binding. * Rename header file to "nvidia,tegra264-gpio.h". --- .../bindings/gpio/nvidia,tegra186-gpio.yaml | 24 +++++++ .../dt-bindings/gpio/nvidia,tegra264-gpio.h | 62 +++++++++++++++++++ 2 files changed, 86 insertions(+) create mode 100644 include/dt-bindings/gpio/nvidia,tegra264-gpio.hdiff --git a/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml b/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml index 2bd620a1099b..b74fc3a8d80d 100644 --- a/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml@@ -86,6 +86,9 @@ properties: - nvidia,tegra234-gpio - nvidia,tegra234-gpio-aon - nvidia,tegra256-gpio + - nvidia,tegra264-gpio + - nvidia,tegra264-gpio-uphy + - nvidia,tegra264-gpio-aon reg-names: items:@@ -110,6 +113,12 @@ properties: ports, in the order the HW manual describes them. The number of entries required varies depending on compatible value. + wakeup-parent: + $ref: /schemas/types.yaml#/definitions/phandle
This type should not be needed, wakeup-parent is defined in dt-shema for interrupt-controllers.
+ description: |
Drop the | from here, there's no formatting to preserve. pw-bot: changes-requested Cheers, Conor.
+ Phandle to the parent interrupt controller used for wake-up. + On Tegra, this typically references the PMC interrupt controller.
Attachments
- signature.asc [application/pgp-signature] 228 bytes