Re: [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch

On Thu, Jan 22, 2026 at 08:26:03PM +0100, Łukasz Majewski wrote:

Hi Conor,

quoted

On Thu, Jan 22, 2026 at 01:58:38PM +0100, Lukasz Majewski wrote:

quoted

This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123}
macros definitions for L2 switch.

Those definitions describe clocks for MoreThanIP switch IP block;
the switch itself and the MAC address lookup table clocks.

Signed-off-by: Lukasz Majewski <redacted>
---
 include/dt-bindings/clock/vf610-clock.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/vf610-clock.h

b/include/dt-bindings/clock/vf610-clock.h index
373644e46747..b6f7b1745cc2 100644 ---
a/include/dt-bindings/clock/vf610-clock.h +++
b/include/dt-bindings/clock/vf610-clock.h @@ -197,6 +197,11 @@
 #define VF610_CLK_TCON1			188
 #define VF610_CLK_CAAM			189
 #define VF610_CLK_CRC			190
-#define VF610_CLK_END			191  

If end is modifiable, it is removable. If you need the define for the
driver, please move it there.

Could you be more specific regarding your comment?

Values in bindings are immutable, so changing a definition is an ABI
break. If you can break the ABI for this definition, then you should
just remove it instead, because it doesn't represent a clock and it is
liable to change when you information comes to light (e.g. this patch).

The VF610_CLK_END has now value 191.

However, there are other clocks in this SoC - like CLK_ESW and
CLK_MAC_TAB{x} - which were not taken into account earlier.

What shall be done?

Shall I remove the VF610_CLK_END entirely?

Or move to the new "end" (as done with this patch)?

If you need VF610_CLK_END for your driver, rather than just using
(VF610_CLK_ESW_MAC_TAB + 1), please move the definition there.