Re: [PATCH v2 2/3] reset: tenstorrent: Add reset controller for Atlantis

Hi Philipp,

On Fri, Jan 23, 2026 at 7:00 AM Philipp Zabel [off-list ref] wrote:

On Do, 2026-01-22 at 16:36 -0600, Anirudh Srinivasan wrote:

quoted

Adds Atlantis Reset Controller and auxiliary device definitions for
reset to share same regmap interface as clock controller.

quoted

+     if (data->active_low ^ assert)
+             val = mask;
+     else
+             val = ~mask;

                val = 0;

The ~mask bits will be ignored anyway.

Ack. Will change.

struct regmap;

quoted

+
+struct atlantis_ccu_adev {
+     struct auxiliary_device adev;
+     struct regmap *regmap;
+};
+
+#define to_atlantis_ccu_adev(_adev) \
+     container_of((_adev), struct atlantis_ccu_adev, adev)

Please use an inline function instead of a macro.

Ack.

quoted

+
+/* RCPU Reset Register Offsets */
+#define RCPU_BLK_RST_REG     0x001c
+#define LSIO_BLK_RST_REG     0x0020
+#define HSIO_BLK_RST_REG     0x000c
+#define PCIE_SUBS_RST_REG    0x0000
+#define MM_RSTN_REG          0x0014

Why not move these into reset-tenstorrent-atlantis.c, they are not part
of the interface between clock and reset drivers.

We were considering putting register offsets like this in separate
header files that are dual licensed. In that case, is it okay to put
it here?

regards
Philipp