On 23/01/2026 08:59, Pritam Manohar Sutar wrote:

Hi Krzysztof,

Thank you for your feedback. 

quoted

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 22 January 2026 07:05 PM
To: Pritam Manohar Sutar <redacted>; robh@kernel.org;
krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com
Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
rosa.pila@samsung.com; dev.tailor@samsung.com;
faraz.ata@samsung.com; muhammed.ali@samsung.com;
selvarasu.g@samsung.com
Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
nodes

On 22/01/2026 14:07, Pritam Manohar Sutar wrote:

quoted

Enable USB PHY and DWC3 USB controllers' nodes.

Signed-off-by: Pritam Manohar Sutar <redacted>
---
 .../boot/dts/exynos/exynosautov920-sadk.dts   | 21

+++++++++++++++++++

quoted

 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts

b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
index f90f7704597c..5896dd69334a 100644

--- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
+++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts

@@ -160,15 +160,20 @@ &xtcxo {
 &usbdrd31_ssphy {
 	dvdd-supply = <&dummy_regulator>;
 	vdd18-supply = <&dummy_regulator>;
+	status = "okay";

You just added the node in the previous patch, so why it cant be enavled
there?

quoted

 };

 &usbdrd31_hsphy {
 	dvdd-supply = <&dummy_regulator>;
 	vdd18-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };

 &usbdrd31_dwc3 {
+	dr_mode = "otg";
+	usb-role-switch;
+	role-switch-default-mode = "peripheral";

Why did you add incomplete node in previous commit?

The commit was added to align with the existing convention of separating 
node addition and enabling logic in USB configurations. This approach is 

There was never such convention for Qualcomm or Samsung. Do not make up
fake conventions.

referenced from commits such as:

No, it is not.

https://lore.kernel.org/all/20250710-resends-july-exynos990-dt-v2-5-55033f73d1b0@mentallysanemainliners.org/ (local)
https://lore.kernel.org/all/20240429-usb-dts-gs101-v2-2-7c1797c9db80@linaro.org/ (local)

Just look at these commits - they add complete node override to DTS. Not
half node now and half node later to the DTS file!

Please let me know if this commit to be merged in previous commit.

Just look at the commits there.

Best regards,
Krzysztof