Thread (7 messages) 7 messages, 2 authors, 2026-01-22

Re: [PATCH v2 1/4] dt-bindings: i2c: add support for AE350 I2C controller

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-01-22 09:50:07
Also in: linux-i2c, linux-riscv, lkml

On 22/01/2026 09:08, Krzysztof Kozlowski wrote:
quoted
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - andestech,qilai-i2c
+          - const: andestech,ae350-i2c
+      - const: andestech,ae350-i2c
Same question as before. Nothing in commit msg explains me above and you
STILL DID NOT send your soc upstream which would help me to understand
To clarify: no top-level bindings for `git grep andestech,ae350`
the relation between SoCs.

Considering you did not even build check previous version, I do not give
you any benefits of the doubt that this is correct code.

Respond to previous review.

That is a NAK and I am dropping it from the patchwork.


Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help