Re: [PATCH RESEND v8 17/21] media: i2c: maxim-serdes: add MAX9296A driver
From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: 2026-01-20 13:34:25
Also in:
linux-gpio, linux-media, linux-staging, lkml
Hi Dumitru, On Mon, Dec 08, 2025 at 04:13:09PM +0200, Dumitru Ceclan via B4 Relay wrote:
+ *ops = max9296a_common_ops; + + ops->versions = priv->info->ops->versions; + ops->modes = priv->info->ops->modes; + ops->needs_single_link_version = priv->info->ops->needs_single_link_version; + ops->needs_unique_stream_id = priv->info->ops->needs_unique_stream_id; + ops->fix_tx_ids = priv->info->ops->fix_tx_ids; + ops->num_phys = priv->info->ops->num_phys; + ops->num_pipes = priv->info->ops->num_pipes; + ops->num_links = priv->info->ops->num_links; + ops->phys_configs = priv->info->ops->phys_configs; + ops->set_pipe_enable = priv->info->ops->set_pipe_enable; + ops->set_pipe_stream_id = priv->info->ops->set_pipe_stream_id; + ops->set_pipe_tunnel_phy = priv->info->ops->set_pipe_tunnel_phy; + ops->set_pipe_tunnel_enable = priv->info->ops->set_pipe_tunnel_enable; + ops->use_atr = priv->info->ops->use_atr; + ops->tpg_mode = priv->info->ops->tpg_mode;
What's the reason for doing these assignments and a copy of the memory? Why not to just keep a pointer to the struct memory instead? I think there's another case of the same. -- Kind regards, Sakari Ailus