Re: [PATCH v3 1/3] dt-bindings: hwmon: ti,tmp108: Add P3T1035,P3T2030
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-01-16 07:22:30
Also in:
linux-doc, linux-hwmon, lkml
On 15/01/2026 12:14, Mayank Mahajan wrote:
quoted hunk ↗ jump to hunk
Document the NXP P3T1035 and P3T2030 compatibles in TMP108. Signed-off-by: Mayank Mahajan <redacted> --- V1 -> V2: - No changes in v2. V2 -> V3: - Add P3T1035 fallback for P3T2030 as they are functionally identical. - Add comment in the description explaining the use of P3T2030. .../devicetree/bindings/hwmon/ti,tmp108.yaml | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-)diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml index a6f9319e068d..1f540c623de6 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml@@ -4,27 +4,35 @@ $id: http://devicetree.org/schemas/hwmon/ti,tmp108.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TMP108/P3T1085(NXP) temperature sensor +title: TMP108/P3T1035/P3T1085/P3T2030 temperature sensor maintainers: - Krzysztof Kozlowski <krzk@kernel.org> description: | - The TMP108/P3T1085(NXP) is a digital-output temperature sensor with a - dynamically-programmable limit window, and under- and overtemperature - alert functions. + The TMP108 or NXP P3T Family (P3T1035, P3T1085 and P3T2030) is a digital- + output temperature sensor with a dynamically-programmable limit window, + and under- and over-temperature alert functions. - P3T1085(NXP) support I3C. + NXP P3T Family (P3T1035, P3T1085 and P3T2030) supports I3C. Datasheets: https://www.ti.com/product/TMP108 https://www.nxp.com/docs/en/data-sheet/P3T1085UK.pdf + https://www.nxp.com/docs/en/data-sheet/P3T1035XUK_P3T2030XUK.pdf + + P3T2030 is functionally identical to P3T1035. Hence, device tree nodes that + use the P3T2030 must provide a fallback compatible string of "nxp,p3t1035"
Drop the sentence. Schema already tells that. Never repeat the schema in free text. It's like adding comments to code: ptr = kzalloc() /* Check for null pointer after allocation */ if (!ptr) return -ENOMEM This is worse coding. Write concise, clearly readable code. With this fixed: Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof