Re: [PATCH 1/3] dt-bindings: gpio: Add Tegra264 support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-01-15 13:29:03
Also in:
linux-gpio, linux-tegra, lkml
On Wed, Jan 14, 2026 at 10:38:44AM +0000, Prathamesh Shete wrote:
Extend the existing Tegra186 GPIO controller device tree bindings with support for the GPIO controller found on Tegra264. The number of pins is slightly different, but the programming model remains the same. Add a new header, include/dt-bindings/gpio/tegra264-gpio.h, that defines port IDs as well as the TEGRA264_MAIN_GPIO() helper, both of which are used in conjunction to create a unique specifier for each pin. Document nvidia,pmc property referencing the PMC node providing the parent interrupt domain. GPIO driver uses this to select the correct
Why do you need to reference parent interrupt not via interrupts but custom phandle?
quoted hunk ↗ jump to hunk
PMC,falling back to compatible-based lookup only if the phandle is absent. Signed-off-by: Prathamesh Shete <redacted> --- .../bindings/gpio/nvidia,tegra186-gpio.yaml | 10 +++ include/dt-bindings/gpio/tegra264-gpio.h | 61 +++++++++++++++++++ 2 files changed, 71 insertions(+) create mode 100644 include/dt-bindings/gpio/tegra264-gpio.hdiff --git a/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml b/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml index 2bd620a1099b..93150504c03c 100644 --- a/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/nvidia,tegra186-gpio.yaml@@ -86,6 +86,9 @@ properties: - nvidia,tegra234-gpio - nvidia,tegra234-gpio-aon - nvidia,tegra256-gpio + - nvidia,tegra264-gpio + - nvidia,tegra264-gpio-uphy + - nvidia,tegra264-gpio-aon reg-names: items:@@ -110,6 +113,10 @@ properties: ports, in the order the HW manual describes them. The number of entries required varies depending on compatible value. + nvidia,pmc: + $ref: /schemas/types.yaml#/definitions/phandle + description: Phandle to the PMC node providing the parent interrupt domain.
You should require it for the new devices/compatibles.
quoted hunk ↗ jump to hunk
+ gpio-controller: true gpio-ranges:@@ -157,6 +164,8 @@ allOf: - nvidia,tegra194-gpio - nvidia,tegra234-gpio - nvidia,tegra256-gpio + - nvidia,tegra264-gpio + - nvidia,tegra264-gpio-uphy then: properties: interrupts:@@ -171,6 +180,7 @@ allOf: - nvidia,tegra186-gpio-aon - nvidia,tegra194-gpio-aon - nvidia,tegra234-gpio-aon + - nvidia,tegra264-gpio-aon then: properties: interrupts:diff --git a/include/dt-bindings/gpio/tegra264-gpio.h b/include/dt-bindings/gpio/tegra264-gpio.h new file mode 100644 index 000000000000..d7baceace474 --- /dev/null +++ b/include/dt-bindings/gpio/tegra264-gpio.h
Use filenames matching compatible or bindings file. nvidia,tegra264-gpio.h Best regards, Krzysztof