Thread (11 messages) 11 messages, 3 authors, 2026-01-14

Re: [PATCH v5 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO

From: Stafford Horne <shorne@gmail.com>
Date: 2026-01-14 15:48:22
Also in: linux-gpio, lkml

On Wed, Jan 14, 2026 at 04:36:23PM +0100, Geert Uytterhoeven wrote:
Hi Stafford,

Thanks for your patch!

On Wed, 14 Jan 2026 at 16:14, Stafford Horne [off-list ref] wrote:
quoted
In commit f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible
string for opencores,gpio") we marked opencores,gpio to be allowed with
brcm,bcm6345-gpio. This was wrong, opencores,gpio is not hardware
equivalent to brcm,bcm6345-gpio. It has a different register map and
is 8-bit vs braodcom which is 32-bit.  Change opencores,gpio to be a
broadcom or Broadcom
Right, thanks for spotting this.
quoted
separate compatible string for MMIO GPIO.

Fixes: f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible string for opencores,gpio")
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
Since v4:
 - New patch.
 - Rebased old patch and rewrote commit message.
The actual patch LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks.

-Stafford
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help