Re: [PATCH v2 2/5] dt-bindings: clock: google,gs101-clock: Add DPU clock management unit
From: Peter Griffin <peter.griffin@linaro.org>
Date: 2026-01-13 09:46:07
Also in:
linux-arm-kernel, linux-clk, linux-samsung-soc, lkml
Hi André, On Mon, 12 Jan 2026 at 14:32, André Draszik [off-list ref] wrote:
On Mon, 2026-01-12 at 14:16 +0000, Peter Griffin wrote:quoted
Add dt schema documentation and clock IDs for the Display Process Unit (DPU) clock management unit (CMU). This CMU feeds IPs such as image scaler, enhancer and compressor. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- Changes in v2 - alphanumeric placement (Krzysztof) --- .../bindings/clock/google,gs101-clock.yaml | 19 ++++++++++++ include/dt-bindings/clock/google,gs101.h | 36 ++++++++++++++++++++++ 2 files changed, 55 insertions(+)diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml index a8176687bb773ae90800b9c256bcccebfdef2e49..00620ab1872db0489dce1823ab500c0062b651f0 100644--- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml@@ -28,6 +28,7 @@ properties: compatible: enum: - google,gs101-cmu-apm + - google,gs101-cmu-dpu - google,gs101-cmu-hsi0 - google,gs101-cmu-hsi2 - google,gs101-cmu-misc@@ -82,6 +83,24 @@ allOf: items: - const: oscclk + - if: + properties: + compatible: + contains: + const: google,gs101-cmu-dpu + + then: + properties: + clocks: + items: + - description: External reference clock (24.576 MHz) + - description: DPU bus clock (from CMU_TOP) + + clock-names: + items: + - const: oscclk + - const: bus + - if: properties: compatible:diff --git a/include/dt-bindings/clock/google,gs101.h b/include/dt-bindings/clock/google,gs101.h index 442f9e9037dc33198a1cee20af62fc70bbd96605..4ee46503663c1f8d9463536c347de5d991474145 100644 --- a/include/dt-bindings/clock/google,gs101.h +++ b/include/dt-bindings/clock/google,gs101.h@@ -634,4 +634,40 @@ #define CLK_GOUT_PERIC1_CLK_PERIC1_USI9_USI_CLK 45 #define CLK_GOUT_PERIC1_SYSREG_PERIC1_PCLK 46 +/* CMU_DPU */Maybe add this block before hsi0 and after apm to keep alphabetic ordering of CMU blocks in this file.
Thanks for the review. Good point, I'll fix that and send a v3. Peter