Thread (12 messages) 12 messages, 4 authors, 2026-01-13

Re: [PATCH v3 1/3] dt-bindings: usb: Add binding for WCH CH334/CH335 hub controller

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-01-13 07:41:20
Also in: linux-arm-kernel, linux-rockchip, linux-usb, lkml

On 13/01/2026 04:27, Chaoyi Chen wrote:
Hi Krzysztof,

On 1/12/2026 10:28 PM, Krzysztof Kozlowski wrote:
quoted
On 12/01/2026 09:59, Chaoyi Chen wrote:
quoted
quoted
quoted
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    usb {
+        dr_mode = "host";
One more thing - drop above line.
Will fix in next version.
quoted
quoted
quoted
quoted
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        hub: hub@1 {
+            compatible = "usb1a86,8091";
+            reg = <1>;
+            reset-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
Are you sure?
I guess what you're concerned about here is the polarity? 
If that's the case, then there's no problem.
Yes, I was wondering whether polarity is set correctly.
Yes, it is active-low, so during normal operation it should be set to high.
Then it is wrong.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help