Re: [PATCH v5 5/5] power: sequencing: Add the Power Sequencing driver for the PCIe M.2 connectors
From: Bartosz Golaszewski <brgl@kernel.org>
Date: 2026-01-08 12:15:27
Also in:
linux-arm-msm, linux-ide, linux-pci, linux-pm, lkml
On Wed, Jan 7, 2026 at 3:11 PM Manivannan Sadhasivam via B4 Relay [off-list ref] wrote:
From: Manivannan Sadhasivam <redacted> This driver is used to control the PCIe M.2 connectors of different Mechanical Keys attached to the host machines and supporting different interfaces like PCIe/SATA, USB/UART etc... Currently, this driver supports only the Mechanical Key M connectors with PCIe interface. The driver also only supports driving the mandatory 3.3v and optional 1.8v power supplies. The optional signals of the Key M connectors are not currently supported. Signed-off-by: Manivannan Sadhasivam <redacted>
This looks good to me, though there are some nits I may fix when applying. I'll pick it up for v7.0 once the bindings are reviewed.
quoted hunk ↗ jump to hunk
+++ b/drivers/power/sequencing/pwrseq-pcie-m2.c@@ -0,0 +1,169 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + * Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com> + */ + +#include <linux/device.h> +#include <linux/mod_devicetable.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_graph.h> +#include <linux/of_platform.h>
It looks like this is a leftover from previous versions and you no longer need it?
+
+static void pwrseq_pcie_free_resources(void *data)
+{
+ struct pwrseq_pcie_m2_ctx *ctx = data;
+
+ regulator_bulk_free(ctx->num_vregs, ctx->regs);
+}I would call it pwrseq_pcie_m2_free_regulators() if you don't mind. Bart