Thread (29 messages) 29 messages, 6 authors, 2026-01-06

Re: [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-01-06 19:20:57
Also in: linux-arm-msm, linux-i2c, linux-media, lkml

On 06/01/2026 20:18, Krzysztof Kozlowski wrote:
On 06/01/2026 19:40, Vijay Kumar Tumati wrote:
quoted
On 11/27/2025 12:12 AM, Krzysztof Kozlowski wrote:
quoted
On Wed, Nov 26, 2025 at 01:38:40AM -0800, Hangxiang Ma wrote:
Look here^
quoted
quoted
quoted
+		};
+
+		cci0: cci@ac7b000 {
Looks completely mis-ordered/sorted. What are the nodes above and below?
Hi Krzysztof, sorry, not sure how you mean exactly. The ones above are 
the pinctrl nodes. Each CCI has two masters using two GPIOs each, one 
Why would pinctrl nodes matter anyhow? Please read how DTS syntax works.
quoted
for clk and one for data. The ones below are the actual CCI HW nodes 
that make use of the pinctrls. I believe this is inline with previous 
generations. Have I missed something? Thanks.
I wrote what is wrong. Is this maintaining proper sorting? Did you read
DTS coding style?

Heh, you received my review 1 day after your posting.

You replied to my review 5-6 weeks after, yet you still expect me to
understand the context and provide clarifications.

There is simpler way: NAK.

You will not get your patches merged with such latency and such replies
not even trying to address the problem or learn about it.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help