Thread (28 messages) 28 messages, 4 authors, 2026-01-02

Re: [PATCH v5 21/21] regulator: s2mps11: enable-gpios is optional on s2mpg1x

From: Bartosz Golaszewski <brgl@kernel.org>
Date: 2026-01-02 11:31:18
Also in: linux-gpio, linux-samsung-soc, lkml

On Fri, Jan 2, 2026 at 12:26 PM André Draszik [off-list ref] wrote:
On Fri, 2026-01-02 at 11:19 +0100, Bartosz Golaszewski wrote:
quoted
On Sat, Dec 27, 2025 at 1:24 PM André Draszik [off-list ref] wrote:
quoted
For s2mpg1x, enable-gpios is optional, but when not given, the driver
is complaining quite verbosely about the missing property.

Refactor the code slightly to avoid printing those messages to the
kernel log in that case.
I don't get the point of this - you added this function in the same
series, why can't it be done right the first time it's implemented?
Sure, I can merge this patch into the refactoring patch 15 - the intention
was to have incremental changes to simplify review.
I'm all for it but introducing issues in one patch and fixing it in
another is a bit too much. :)

Bartosz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help