[PATCH v19 03/10] power: reset: reboot-mode: Add support for predefined reboot modes
From: Shivendra Pratap <hidden>
Date: 2025-12-28 17:20:59
Also in:
linux-arm-kernel, linux-arm-msm, linux-pm, lkml
Subsystem:
arm/qualcomm mailing list, system reset/shutdown drivers, the rest · Maintainers:
Sebastian Reichel, Linus Torvalds
reboot-mode based drivers can define a reboot-mode by adding it under the reboot-mode node in device tree. This limits such drivers, to define any predefined reboot-modes statically within the driver and creates a dependency on device-tree. Introduce a list for predefined modes in the reboot-mode framework and process the predefined reboot-modes along with the device-tree defined reboot-modes. Modify existing reboot-mode based drivers to initialize the predefined list-head as empty. This patch enables a reboot mode driver to define reboot-modes through a predefined static list, in addition to the device-tree based reboot-modes. Signed-off-by: Shivendra Pratap <redacted> --- drivers/power/reset/nvmem-reboot-mode.c | 1 + drivers/power/reset/qcom-pon.c | 1 + drivers/power/reset/reboot-mode.c | 28 ++++++++++++++++++++++------ drivers/power/reset/syscon-reboot-mode.c | 1 + include/linux/reboot-mode.h | 9 +++++++++ 5 files changed, 34 insertions(+), 6 deletions(-)
diff --git a/drivers/power/reset/nvmem-reboot-mode.c b/drivers/power/reset/nvmem-reboot-mode.c
index b3d21d39b0f732254c40103db1b51fb7045ce344..b02a2af31aac52cb0ab19cf5d4d315d17c208f6e 100644
--- a/drivers/power/reset/nvmem-reboot-mode.c
+++ b/drivers/power/reset/nvmem-reboot-mode.c@@ -44,6 +44,7 @@ static int nvmem_reboot_mode_probe(struct platform_device *pdev) nvmem_rbm->reboot.dev = &pdev->dev; nvmem_rbm->reboot.write = nvmem_reboot_mode_write; + INIT_LIST_HEAD(&nvmem_rbm->reboot.predefined_modes); nvmem_rbm->cell = devm_nvmem_cell_get(&pdev->dev, "reboot-mode"); if (IS_ERR(nvmem_rbm->cell)) {
diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
index ccce1673b2ec47d02524edd44811d4f528c243e8..bf7b9f0bcdcc4c168aa7ff8d6494122d898814b5 100644
--- a/drivers/power/reset/qcom-pon.c
+++ b/drivers/power/reset/qcom-pon.c@@ -75,6 +75,7 @@ static int qcom_pon_probe(struct platform_device *pdev) pon->reboot_mode.dev = &pdev->dev; pon->reason_shift = reason_shift; pon->reboot_mode.write = qcom_pon_reboot_mode_write; + INIT_LIST_HEAD(&pon->reboot_mode.predefined_modes); error = devm_reboot_mode_register(&pdev->dev, &pon->reboot_mode); if (error) { dev_err(&pdev->dev, "can't register reboot mode\n");
diff --git a/drivers/power/reset/reboot-mode.c b/drivers/power/reset/reboot-mode.c
index 1e85f2c052c916e153c7c9ac0b184c91d7153402..877c2459a3b2e47679ee2e9fbb9b0329dc3b1e0f 100644
--- a/drivers/power/reset/reboot-mode.c
+++ b/drivers/power/reset/reboot-mode.c@@ -16,12 +16,6 @@ #define PREFIX "mode-" -struct mode_info { - const char *mode; - u64 magic; - struct list_head list; -}; - static u64 get_reboot_mode_magic(struct reboot_mode_driver *reboot, const char *cmd) { const char *normal = "normal";
@@ -72,6 +66,7 @@ static int reboot_mode_notify(struct notifier_block *this, */ int reboot_mode_register(struct reboot_mode_driver *reboot) { + struct mode_info *info_predef; struct mode_info *info; struct mode_info *next; struct property *prop;
@@ -83,6 +78,9 @@ int reboot_mode_register(struct reboot_mode_driver *reboot) INIT_LIST_HEAD(&reboot->head); + if (!np) + goto predefined_modes; + for_each_property_of_node(np, prop) { if (strncmp(prop->name, PREFIX, len)) continue;
@@ -124,6 +122,24 @@ int reboot_mode_register(struct reboot_mode_driver *reboot) list_add_tail(&info->list, &reboot->head); } +predefined_modes: + list_for_each_entry(info_predef, &reboot->predefined_modes, list) { + info = kzalloc(sizeof(*info), GFP_KERNEL); + if (!info) { + ret = -ENOMEM; + goto error; + } + + info->mode = kstrdup_const(info_predef->mode, GFP_KERNEL); + if (!info->mode) { + ret = -ENOMEM; + goto error; + } + + info->magic = info_predef->magic; + list_add_tail(&info->list, &reboot->head); + } + reboot->reboot_notifier.notifier_call = reboot_mode_notify; register_reboot_notifier(&reboot->reboot_notifier);
diff --git a/drivers/power/reset/syscon-reboot-mode.c b/drivers/power/reset/syscon-reboot-mode.c
index eb7fc5b7d6a7ed8a833d4920991c4c40b5b13ca7..74e2e14c5d87c54ac24ef63c7905b3266d736439 100644
--- a/drivers/power/reset/syscon-reboot-mode.c
+++ b/drivers/power/reset/syscon-reboot-mode.c@@ -50,6 +50,7 @@ static int syscon_reboot_mode_probe(struct platform_device *pdev) syscon_rbm->reboot.dev = &pdev->dev; syscon_rbm->reboot.write = syscon_reboot_mode_write; syscon_rbm->mask = 0xffffffff; + INIT_LIST_HEAD(&syscon_rbm->reboot.predefined_modes); syscon_rbm->map = syscon_node_to_regmap(pdev->dev.parent->of_node); if (IS_ERR(syscon_rbm->map))
diff --git a/include/linux/reboot-mode.h b/include/linux/reboot-mode.h
index a359dc0c6dede0ac5ce67190a00d46a7e7856707..bddec9b7f94187dcb056540df79eea34c25b1d0d 100644
--- a/include/linux/reboot-mode.h
+++ b/include/linux/reboot-mode.h@@ -4,11 +4,20 @@ #include <linux/bitfield.h> #include <linux/bits.h> +#include <linux/reboot.h> #include <linux/types.h> +struct mode_info { + const char *mode; + u64 magic; + struct list_head list; +}; + struct reboot_mode_driver { struct device *dev; struct list_head head; + /* List of predefined reboot-modes, a reboot-mode-driver may populate. */ + struct list_head predefined_modes; int (*write)(struct reboot_mode_driver *reboot, u64 magic); struct notifier_block reboot_notifier; };
--
2.34.1