On Tue, 16 Dec 2025 07:01:49 +0100
Krzysztof Kozlowski [off-list ref] wrote:

On Thu, Dec 11, 2025 at 05:38:45PM +0100, Kory Maincent (TI.com) wrote:

quoted

diff --git a/Documentation/devicetree/bindings/display/tilcdc/tilcdc.yaml

b/Documentation/devicetree/bindings/display/tilcdc/tilcdc.yaml new file
mode 100644 index 0000000000000..34ac1fd04d5c6

--- /dev/null
+++ b/Documentation/devicetree/bindings/display/tilcdc/tilcdc.yaml  

Filename based on compatible, so for example ti,am33xx-tilcdc.yaml or
worse case ti,tilcdc.yaml (see writing bindings and writing schema docs)

Oh indeed forgot that rule. Sorry.
 

quoted

@@ -0,0 +1,96 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/tilcdc/tilcdc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI LCD Controller, found on AM335x, DA850, AM18x and OMAP-L138
+
+maintainers:
+  - Kory Maincent <kory.maincent@bootlin.com>
+
+properties:
+  compatible:
+    enum:
+      - ti,am33xx-tilcdc
+      - ti,da850-tilcdc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+
+  ti,hwmods:
+    $ref: /schemas/types.yaml#/definitions/string
+    description:
+      Name of the hwmod associated to the LCDC
+
+  max-bandwidth:  

constraints? Is '1' valid? Is INT_MAX valid as well?

These maximums values are kind of software only check. See:
https://elixir.bootlin.com/linux/v6.18.1/source/drivers/gpu/drm/tilcdc/tilcdc_crtc.c#L846
but there are no mainline devicetree using it. We have to keep them because
they were present in the text binding.

I think we can still add a maximum constraint matching the tilcdc maximum
resolution value.

...

Drop unused label. Generic node name, e.g. "display-controller" or
"lcd-controller".

Ok, thank you for the review!

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com