Re: [PATCH v6 4/5] mmc: sdhci-msm: Add Device tree parsing logic for DLL settings
From: Konrad Dybcio <hidden>
Date: 2025-12-16 14:29:34
Also in:
linux-arm-msm, linux-mmc, lkml
On 12/15/25 1:00 PM, Ram Prakash Gupta wrote:
From: Sachin Gupta <redacted> This update introduces the capability to configure HS200 and HS400 DLL settings via the device tree and parsing it. Signed-off-by: Sachin Gupta <redacted> Signed-off-by: Ram Prakash Gupta <redacted> ---
[...]
+#define DLL_SIZE 10
+static int sdhci_msm_dt_parse_dll_info(struct device *dev, struct sdhci_msm_host *msm_host)
+{
+ u32 *dll_table = &msm_host->dll[0].dll_config;
+ int ret;
+
+ msm_host->artanis_dll = false;
+
+ ret = of_property_read_variable_u32_array(dev->of_node,
+ "qcom,dll-presets",
+ dll_table, DLL_SIZE, DLL_SIZE);
+ if (ret == DLL_SIZE)
+ msm_host->artanis_dll = true;This feels backwards.. can we first somehow determine whether this platform has the artanis_dll (whatever that is since you didn't explain) and then make decisions on what to retrieve from the DT & how to interpret it?
quoted hunk ↗ jump to hunk
+ return ret; +} + static int sdhci_msm_probe(struct platform_device *pdev) { struct sdhci_host *host;@@ -2580,6 +2612,15 @@ static int sdhci_msm_probe(struct platform_device *pdev) msm_host->saved_tuning_phase = INVALID_TUNING_PHASE; + /* + * Parse HSR dll only when property is present in DT. + */
/* Parse ... */, it's short enough Probably also "DLL" Konrad