Re: [PATCH RESEND 2/3] arm64: dts: amlogic: Fix the register name of the 'DBI' region
From: Neil Armstrong <neil.armstrong@linaro.org>
Date: 2025-11-03 09:47:53
Also in:
linux-amlogic, linux-arm-kernel, linux-pci, lkml
On 11/1/25 05:29, Manivannan Sadhasivam wrote:
quoted hunk ↗ jump to hunk
DT incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must have region for DWC controllers as it has the Root Port and controller specific registers, while ELBI has optional registers. Hence, fix the DT for both Meson platforms. Cc: stable+noautosel@kernel.org # Driver dependency Fixes: 5b3a9c20926e ("arm64: dts: meson-axg: add PCIe nodes") Fixes: 1f8607d59763 ("arm64: dts: meson-g12a: Add PCIe node") Signed-off-by: Manivannan Sadhasivam <redacted> --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++-- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index 04fb130ac7c6a498f7e8029aeaa7e511cbfe815d..e95c91894968b2c8b3b8e96a5f5e85cd60f3e085 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi@@ -208,7 +208,7 @@ pcieA: pcie@f9800000 { reg = <0x0 0xf9800000 0x0 0x400000>, <0x0 0xff646000 0x0 0x2000>, <0x0 0xf9f00000 0x0 0x100000>; - reg-names = "elbi", "cfg", "config"; + reg-names = "dbi", "cfg", "config"; interrupts = <GIC_SPI 177 IRQ_TYPE_EDGE_RISING>; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>;@@ -234,7 +234,7 @@ pcieB: pcie@fa000000 { reg = <0x0 0xfa000000 0x0 0x400000>, <0x0 0xff648000 0x0 0x2000>, <0x0 0xfa400000 0x0 0x100000>; - reg-names = "elbi", "cfg", "config"; + reg-names = "dbi", "cfg", "config"; interrupts = <GIC_SPI 167 IRQ_TYPE_EDGE_RISING>; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>;diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi index dcc927a9da80246da43391f9f90049c3570f10d2..ca455f634834b5a52db8ff4e6ebca35a87ea17b7 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi@@ -138,7 +138,7 @@ pcie: pcie@fc000000 { reg = <0x0 0xfc000000 0x0 0x400000>, <0x0 0xff648000 0x0 0x2000>, <0x0 0xfc400000 0x0 0x200000>; - reg-names = "elbi", "cfg", "config"; + reg-names = "dbi", "cfg", "config"; interrupts = <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>